Fixed error upon stopping recording. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-chris
reviewed
Jan 19, 2018
There was a problem hiding this comment.
I wonder if this is the right way to fix this. Sure it works, but the record() method is still called although it shouldn't, given that finish() have been called before.
I'm not using WebAudioRecorder.js (only the workers) so I cannot check this but cancelling the onaudioprocess callback before sending the finish command to the worker might do the trick.
this.processor.onaudioprocess = null; // <= add this
this.processor.disconnect();
delete this.processor;
this.worker.postMessage({ command: "finish" });
| @@ -39,7 +39,7 @@ function record(buffer) { | |||
| if (bufferCount++ < maxBuffers) | |||
| if (encoder) | |||
| encoder.encode(buffer); | |||
| else | |||
| else if (recBuffers) | |||
There was a problem hiding this comment.
This fix is wrong. You need to wrap the top level condition with brackets otherwise you will trigger a timeout with the following else.
if (bufferCount++ < maxBuffers) {
if (encoder)
encoder.encode(buffer);
else if (recBuffers)
recBuffers.push(buffer);
} else
self.postMessage({ command: "timeout" });
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents occasional error message upon stopping recording.